PayloadWriter: Only set data_offset for operations that reference blobs #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenxiaolong
changed the title
This fixes `data_offset` being set for `ZERO` and `DISCARD` operations, which prevents some images (eg. `ossi`) from being flashed due to update_engine's strict field validation. Signed-off-by: Andrew Gunnerson <[email protected]>
|
This was a problem in the Python implementation too. I guess there are 0 people who use avbroot with OnePlus stock OTAs :) |
chenxiaolong
added a commit
that referenced
this pull request
Sep 7, 2023
Signed-off-by: Andrew Gunnerson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes
data_offsetbeing set forZEROandDISCARDoperations, which prevents some images (eg.ossi) from being flashed due to update_engine's strict field validation.