cli/avb: Update kernel cmdline descriptor for devices that use dm=
#205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenxiaolong
force-pushed
the
cmdline
branch
3 times, most recently
from
1f4b926
to
d79b050
Compare
Older Pixel devices (and ChromiumOS) specify the dm-verity options on the kernel command line using a custom `dm=` parameter instead of using dm-init or a userspace helper. This commit updates the avb pack and repack commands to automatically update the relevant kernel command line descriptor if it exists. Issue: #203 Signed-off-by: Andrew Gunnerson <[email protected]>
chenxiaolong
force-pushed
the
cmdline
branch
from
d79b050
to
6f56596
Compare
chenxiaolong
added a commit
that referenced
this pull request
Nov 14, 2023
Signed-off-by: Andrew Gunnerson <[email protected]>
pixincreate
reviewed
Nov 15, 2023
| // Starting sector. | ||
| result.push('0'); | ||
| // Sector count. | ||
| write!(&mut result, " {}", descriptor.image_size / 512).unwrap(); |
There was a problem hiding this comment.
Wouldn't using unwrap() result in the to panic if it fails? I suggest using unwrap_or_default(),unwrap_or(), or better using a map() instead.. 😅
There was a problem hiding this comment.
Normally yes, but formatting into a String is guaranteed to never fail (unless the system runs out of memory, but Rust will panic in that case anyway).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Older Pixel devices (and ChromiumOS) specify the dm-verity options on the kernel command line using a custom
dm=parameter instead of using dm-init or a userspace helper. This commit updates the avb pack and repack commands to automatically update the relevant kernel command line descriptor if it exists.Issue: #203