-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transition to JupyterLab 2.0.0 #21
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although the new version of the dependency cannot be directly applied to jupyterlab 1.0 after updating, it is very effective for jupyterlab 2.0
I think you can delete |
@zhytang ah that would make everything more in line with the current cookiecutter template to create a jupyterlab extension, but I didn't see package-lock.json be in the .gitignore, so I think the cookiecutter is opinionated towards including it. |
when NPM is used to publish packages, package-lock.json will not be published, so I think we can add it to the .gitignore. |
@zhytang i updated this extension based on the jupyterlab extensions cookiecutter repo: https://github.com/jupyterlab/extension-cookiecutter-ts I didn't remove package-lock.json as it would go against the typical practice I've seen across many other jupyterlab extensions as well as this repo. |
@chaoleili if you have time, this is ready for review/merge I'd say! |
Thanks a lot for your contribution! 🎉 |
JupyterLab 2.0.0 is out, and this extension have conflicting dependencies with its core packages. This PR is me following the JupyterLab migration guide referenced below, as I have now done for many other repositories successfully.
PR Summary
References