Issue ktorio#1903. Added code to parse the url if valid else return null

chetankokil · Aug 28, 2022 · 886c276 · 886c276
1 parent ecd1421
commit 886c276
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 1 deletion.
diff --git a/ktor-http/common/src/io/ktor/http/Url.kt b/ktor-http/common/src/io/ktor/http/Url.kt
@@ -116,7 +116,11 @@ public class Url internal constructor(
         return urlString.hashCode()
     }
 
-    public companion object
+    public companion object {
+        public fun parse(urlString: String) : Url? {
+            return Url(urlString)
+        }
+    }
 }
 
 @Suppress("UNUSED_PARAMETER")

diff --git a/ktor-http/common/test/io/ktor/tests/http/UrlTest.kt b/ktor-http/common/test/io/ktor/tests/http/UrlTest.kt
@@ -302,4 +302,18 @@ class UrlTest {
         val url = Url(urlString)
         assertEquals(urlString, "$url")
     }
+
+
+    @Test
+    fun testUrlWithGivenString() {
+        val validUrl = "https://localhost:8080/validUrl"
+        assertNotNull(Url.parse(validUrl), "Invalid Url")
+    }
+
+
+    @Test
+    fun testInvalidUrlReturnsNull() {
+        val bogusUrl = "bogus"
+        assertNull(Url.parse(bogusUrl))
+    }
 }