Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update encoding everytime when SubprocessTabule is initialized #378

Merged
merged 1 commit into from
Mar 10, 2024

Conversation

chezou
Copy link
Owner

@chezou chezou commented Mar 10, 2024

Description

Enforce updating encoding and java_process options when SubprocessTabula is used.

Motivation and Context

This is an improvement that allows the flexibility that was available before jpype support.
Hope to fix #377 as well.

How Has This Been Tested?

unit test

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I read the contributing document.
  • My code follows the code style of this project with running linter.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@chezou chezou merged commit 235e25c into master Mar 10, 2024
2 checks passed
@chezou chezou deleted the update-encoding branch March 10, 2024 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Encoding still being overridden even after fix to #371.
1 participant