More robust options handling

CHANGELOG.md

@@ -12,6 +12,9 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/).
 
 - Requires `@sap/cds-dk` 4.3.0, no more polyfill for older versions
 
+### Fixed
+
+- Options can be provided partially
 
 ## Version 0.1.1 - 2021-07-06
 

index.js

@@ -2,8 +2,10 @@ const cds = require ('@sap/cds-dk')
 const swaggerUi = require('swagger-ui-express')
 const express = require('express')
 
-module.exports = (options={basePath:'/$api-docs'}) => {
+module.exports = (options={}) => {
+  options = Object.assign({ basePath:'/$api-docs' }, options)
   const router = express.Router()
+
   cds.on ('serving', service => {
     if (!isOData (service))  return
     const apiPath = options.basePath+service.path

tests/app/server.js

@@ -1,6 +1,11 @@
 const cds = require ('@sap/cds')
 const cds_swagger = require('../..')
 
-cds.on ('bootstrap', app => app.use(cds_swagger()) )
-
 module.exports = cds.server
+
+let options = {}
+if (process.env.TEST_OPTIONS) {
+  options = JSON.parse(process.env.TEST_OPTIONS)
+}
+
+cds.on ('bootstrap', app => app.use(cds_swagger(options)) )

tests/server-options.test.js

@@ -0,0 +1,20 @@
+process.env.TEST_OPTIONS = JSON.stringify({basePath:'/test-base', diagram:false})
+
+const cds = require('@sap/cds/lib')
+const { GET, expect } = cds.test.in(__dirname, 'app').run('serve', 'all')
+
+describe('with options', ()=>{
+  afterAll(() =>{ delete process.env.TEST_OPTIONS })
+
+  test('Main HTML', async()=>{
+    const { status } = await GET `/test-base/browse`
+    expect (status) .equal (200)
+  })
+
+  test('Diagram', async()=>{
+    const { status, data } = await GET `/test-base/browse/swagger-ui-init.js`
+    expect (status) .equal (200)
+    expect (data) .not.to.contain('yuml')
+  })
+
+})

tests/server.test.js

@@ -5,16 +5,21 @@ describe('Swagger UI', ()=>{
 
   test('Service endpoint', async()=>{
     const { status } = await GET `/browse/$metadata`
-    expect (status ) .equal (200)
+    expect (status) .equal (200)
   })
   test('Main HTML', async()=>{
     const { status } = await GET `/$api-docs/browse`
-    expect (status ) .equal (200)
+    expect (status) .equal (200)
+  })
+  test('Diagram', async()=>{
+    const { status, data } = await GET `/$api-docs/browse/swagger-ui-init.js`
+    expect (status) .equal (200)
+    expect (data) .to.contain('yuml')
   })
   test('preview link in index.html', async()=>{
     const { status,data } = await GET `/`
-    expect (status ) .equal (200)
-    expect (data). match (/Show in Swagger UI/i)
+    expect (status) .equal (200)
+    expect (data) .match (/Show in Swagger UI/i)
   })
 
 })