Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wire up iTunesGrouping to the ID3TagContentReader #92

Merged
merged 1 commit into from
Oct 2, 2022

Conversation

jverkoey
Copy link
Contributor

The frame key was already defined, there just wasn't a convenience method exposed on ID3TagContentReader.

Provide a general summary of your changes

Types of changes

  • Bug fix 🐛 (non-breaking change which fixes an issue)
  • New feature ✨ (non-breaking change which adds functionality)
  • Breaking change 💥 (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project 🍻.
  • I have read the CONTRIBUTING document 👥.
  • I have added tests to cover my changes 🎉.
  • All new and existing tests passed ✅.

The frame key was already defined, there just wasn't a convenience method exposed on ID3TagContentReader.
@chicio
Copy link
Owner

chicio commented Sep 26, 2022

Thank you for your contribution @jverkoey 🙏. I will merge and release a new version of ID3TagEditor in the following days. 🚀

@codecov
Copy link

codecov bot commented Sep 26, 2022

Codecov Report

Merging #92 (d2d9d66) into main (d2906ef) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main      #92      +/-   ##
==========================================
- Coverage   94.96%   94.91%   -0.05%     
==========================================
  Files         153      153              
  Lines        4266     4268       +2     
==========================================
  Hits         4051     4051              
- Misses        215      217       +2     
Impacted Files Coverage Δ
Source/Tag/ID3TagContentReader.swift 87.71% <0.00%> (-1.57%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@chicio chicio merged commit 3310b3f into chicio:main Oct 2, 2022
@chicio
Copy link
Owner

chicio commented Oct 2, 2022

Going to release today. I will add you to the contributors. Thanks again for the support 🙏

@jverkoey
Copy link
Contributor Author

jverkoey commented Oct 2, 2022

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants