Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add statusChanged event for status synchronization with 3th parties #191

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pablodgonzalez
Copy link

No description provided.

@pablodgonzalez
Copy link
Author

@chieffancypants You could check this pull request?
I use this event for synchronizing the loading bar with other visuals elements. But is the bar which controlling load percentage
Cheers!

@faceleg
Copy link
Collaborator

faceleg commented Mar 16, 2016

How frequently does this event get called? My only concern is that this could cause performance issues.

If this is the case, then it should be off by default and turned on via a config flag.

Also, PR's should be accompanied by appropriate unit tests.

@chieffancypants thoughts?

@chieffancypants
Copy link
Owner

Is there still a huge performance difference between $broadcast and $emit? If so, this should be changed to $emit, and just force people to listen on $rootScope, which I believe is way more common now anyway.

@faceleg
Copy link
Collaborator

faceleg commented Mar 16, 2016

Agree that listening on $rootScope is fine for this (therefore $emit)

I'll take @chieffancypants' silence on the config flag and off by default to mean he agrees. And tests :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants