Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid multiple interceptor instances due factory #365

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

xemle
Copy link

@xemle xemle commented Aug 7, 2017

What issue is this PR resolving? Alternatively, please describe the bugfix/enhancement this PR aims to provide

Replaced anonymous factory by named factory for better caching and reuse in the $injector service.

We had problems with protractor-http-mock where the interceptor was instantiated multiple times due the anonymous factory and caused timeouts in protractor.

Have you provided unit tests that either prove the bugfix or cover the enhancement?

I've checked the tests and nothing breaks. If you know how to test it, I will to my very best to create one.

Related issues

Replaced anonymous factory by named factory for better caching and
reusage in the $injector service
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant