main/eventlog: drop #2708
Merged
main/eventlog: drop #2708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vendors its own eventlog with no option to use system one
unused, its -devel package conflicts with syslog-ng-devel (which vendors and installs its own copy for reasons)
triallax
force-pushed
the
drop-eventlog
branch
from
3cb6faa
to
c649105
Compare
|
i think if things link a vendored copy they should at least do it statically. otherwise in the future eventlog might be readded for some reason and then it just conflicts again so, either make it link system, or make it link the vendored one without installing a /usr/lib/whatever.so |
|
the vendoring should be fixed, but this technically does not change anything from current status other than dropping the other package so it's fine for now |
|
sure, we can forget about it forever and not fix it |
|
there |
|
ty vm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i could also probably make syslog-ng link against system eventlog, but idk