Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moving mouse breaks pie chart #51

Closed
pevers opened this issue May 8, 2014 · 4 comments · Fixed by #52
Closed

Moving mouse breaks pie chart #51

pevers opened this issue May 8, 2014 · 4 comments · Fixed by #52

Comments

@pevers
Copy link

pevers commented May 8, 2014

Dunno if this is a stupid question, but if I choose the pie chart from:

http://chinmaymk.github.io/angular-charts/

And i move my mouse in the pie-chart while it is drawing the animation. The chart will get some nasty gaps and break. This will only happen if the user is moving the mouse within the graph.

Screenshot from 2014-05-08 16:53:35.png | uploaded via ZenHub
soyuka added a commit to soyuka/angular-charts that referenced this issue May 8, 2014
@soyuka
Wait for pie transition to complete before listening for events on mo…
6808a66 
…useover (tooltips) Fix chinmaymk#51
@soyuka soyuka mentioned this issue May 8, 2014
Merged
@soyuka
Copy link
Collaborator

soyuka commented May 8, 2014

Indeed, I noticed that before but I didn't found the thing that caused it!

It's the tooltip listeners that were listening before the transition completes, and as it modifies the Pie structure it was failing.

@soyuka soyuka mentioned this issue May 8, 2014
Closed
@pevers
Copy link
Author

pevers commented May 8, 2014

Thanks a lot! Your patch fixes this problem!

@pevers pevers closed this as completed May 8, 2014
@soyuka
Copy link
Collaborator

soyuka commented May 9, 2014

Please re-open as the PR isn't merged thanks!

@pevers
Copy link
Author

pevers commented May 9, 2014

Sorry, reopened the issue.

@pevers pevers reopened this May 9, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Wait for pie transition to complete before listening for events soyuka/angular-charts
2 participants
@soyuka @pevers