-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply fixes after merging changes from caliptra-rtl #215
Conversation
Links to coverage and verification reports for this PR (#215) are available at https://chipsalliance.github.io/Cores-VeeR-EL2/ |
What script is responsible for generating el2_pdef.vh? An important recent change was to convert 'bit' types to 'logic' for lint cleanliness. Is that change merged to the generator script? |
design/ifu/el2_ifu_mem_ctl.sv
Outdated
genvar i; | ||
generate | ||
for (i = 0; i < pt.ICACHE_NUM_WAYS; i = i + 1) begin | ||
assign ic_debug_way[i] = (ic_debug_way_enc == i[1:0]); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[verible-verilog-format] reported by reviewdog 🐶
assign ic_debug_way[i] = (ic_debug_way_enc == i[1:0]); | |
assign ic_debug_way[i] = (ic_debug_way_enc == i[1:0]); |
design/ifu/el2_ifu_mem_ctl.sv
Outdated
for (i = 0; i < pt.ICACHE_NUM_WAYS; i = i + 1) begin | ||
assign ic_debug_way[i] = (ic_debug_way_enc == i[1:0]); | ||
end | ||
endgenerate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[verible-verilog-format] reported by reviewdog 🐶
endgenerate | |
endgenerate |
for (i = 0; i < pt.ICACHE_NUM_WAYS; i = i + 1) begin | ||
assign ic_debug_way[i] = (ic_debug_way_enc == i[1:0]); | ||
end | ||
endgenerate | ||
|
||
assign ic_debug_tag_wr_en[pt.ICACHE_NUM_WAYS-1:0] = {pt.ICACHE_NUM_WAYS{ic_debug_wr_en & ic_debug_tag_array}} & ic_debug_way[pt.ICACHE_NUM_WAYS-1:0] ; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[verible-verilog-format] reported by reviewdog 🐶
assign ic_debug_tag_wr_en[pt.ICACHE_NUM_WAYS-1:0] = {pt.ICACHE_NUM_WAYS{ic_debug_wr_en & ic_debug_tag_array}} & ic_debug_way[pt.ICACHE_NUM_WAYS-1:0] ; | |
assign ic_debug_tag_wr_en[pt.ICACHE_NUM_WAYS-1:0] = {pt.ICACHE_NUM_WAYS{ic_debug_wr_en & ic_debug_tag_array}} & ic_debug_way[pt.ICACHE_NUM_WAYS-1:0] ; |
design/ifu/el2_ifu_mem_ctl.sv
Outdated
(ic_debug_way_enc[0] == 1'b0) }; | ||
genvar i; | ||
generate | ||
for (i = 0; i < pt.ICACHE_NUM_WAYS; i = i + 1) begin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All generate block statements must have a label [Style: generate-statements] [generate-label]
Hi @calebofearth, the script that generates |
@@ -1632,8 +1632,9 @@ assign ic_debug_rd_en = dec_tlu_ic_diag_pkt.icache_rd_valid ; | |||
assign ic_debug_wr_en = dec_tlu_ic_diag_pkt.icache_wr_valid ; | |||
|
|||
|
|||
assign ic_debug_way[pt.ICACHE_NUM_WAYS-1:0] = {(ic_debug_way_enc[0] == 1'b1), | |||
(ic_debug_way_enc[0] == 1'b0) }; | |||
for (genvar i = 0; i < pt.ICACHE_NUM_WAYS; i = i + 1) begin : ic_debug_way_loop |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All generate block labels must start with g_ or gen_ [Style: generate-constructs] [generate-label-prefix]
9666bf9
to
0ca2f4f
Compare
bd42266
to
0ca2f4f
Compare
Links to coverage and verification reports for this PR (#215) are available at https://chipsalliance.github.io/Cores-VeeR-EL2/ |
1 similar comment
Links to coverage and verification reports for this PR (#215) are available at https://chipsalliance.github.io/Cores-VeeR-EL2/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This change:
design/el2_pdef.vh
file, which is generated by the flow,veer.config
produce parameter struct using logic type, instead of bit,