Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend new APB defines in integration document #285

Merged
merged 2 commits into from
Dec 9, 2023

Conversation

steven-bellock
Copy link
Contributor

Follow-up to #279.

Signed-off-by: Steven Bellock [email protected]

@steven-bellock
Copy link
Contributor Author

@Nitsirks now that I look at this, why is CALIPTRA_APB_DATA_WIDTH configurable by the Integrator? This should be an unconfigurable 32-bits.

@Nitsirks
Copy link
Contributor

Nitsirks commented Nov 6, 2023 via email

steph-morton
steph-morton previously approved these changes Dec 4, 2023
@calebofearth
Copy link
Collaborator

calebofearth commented Dec 4, 2023

As-is, this PR still suggests that the APB interface signals are integrator configurable.
To implement changes from the discussion above, we should actually be defining all of the APB signals in Table 5 using a hardcoded width (so, APB_USER_REQ_WIDTH is replaced by 32) and removing APB interface defines from Table 3.

EDIT: This recommendation is only for edits to the specification (Tables 3 and 5); I do not suggest any RTL modifications at this stage.

@andreslagarcavilla
Copy link
Collaborator

Unclear if this is ready for merge

@steven-bellock
Copy link
Contributor Author

Unclear if this is ready for merge

No, I'll need to revise it.

APB defines are not meant to be user-configurable.

Signed-off-by: Steven Bellock <[email protected]>
@steven-bellock
Copy link
Contributor Author

@calebofearth @Nitsirks I deleted APB from Table 3 but I think it's fine to have the macro name in the Width column, especially since Table 8 uses them.

@andreslagarcavilla andreslagarcavilla merged commit da85b85 into chipsalliance:main Dec 9, 2023
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants