-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend new APB defines in integration document #285
Extend new APB defines in integration document #285
Conversation
Follow-up to chipsalliance#279. Signed-off-by: Steven Bellock <[email protected]>
@Nitsirks now that I look at this, why is |
You are right - it's probably best if none of the APB parameters are configurable.
I think early on these got put in this list, but we never tested them and there is no reason for them to be configurable. Integrators should put a gasket here to comply with the caliptra settings.
Can/should we update the integration spec again to remove all of these APB defines as integration defines?
|
As-is, this PR still suggests that the APB interface signals are integrator configurable. EDIT: This recommendation is only for edits to the specification (Tables 3 and 5); I do not suggest any RTL modifications at this stage. |
Unclear if this is ready for merge |
No, I'll need to revise it. |
APB defines are not meant to be user-configurable. Signed-off-by: Steven Bellock <[email protected]>
@calebofearth @Nitsirks I deleted APB from Table 3 but I think it's fine to have the macro name in the Width column, especially since Table 8 uses them. |
Follow-up to #279.
Signed-off-by: Steven Bellock [email protected]