Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade bitmanip v.0.92 to v.0.93, enable simultaneous use with v.1.00 #834

Merged

Conversation

vogelpi
Copy link
Contributor

@vogelpi vogelpi commented Dec 2, 2021

The main changes implemented by this PR are:

  1. Support for bitmanip draft v.0.92 is dropped.
  2. Remaining bitmanip instructions not ratified as part of v.1.00 of the bitmanip spec are upgraded to the latest draft (v.0.93).
  3. Simultaneous use of the v.1.00 bitmanip instructions and those instructions only part of draft v.0.93 is enabled.
  4. Rename bext/bdep to bcompress/bdecompress. This is part of v.0.94. But it's needed as in v.0.93 as well as in v.1.00 sbext from Zbs is renamed to bext, leading to two completely different instructions having the same name.
  5. Increase the MAX_INSTR_STR_LEN parameter to accomodate longer instruction names bdecompressw has 12 characters).

@vogelpi
Copy link
Contributor Author

vogelpi commented Dec 2, 2021

@weicaiyang it would be great if you could have a look at this.

@vogelpi
Copy link
Contributor Author

vogelpi commented Dec 2, 2021

@silabs-hfegran in the end I decided not to split the remaining instructions into the sub-extensions as you did for v1.0.0. The reason is that the remaining sub-extensions are still overlapping and I thought that handling this overlapping wasn't worth the effort.

The main changes implemented by this PR are:
1. Support for bitmanip draft v.0.92 is dropped.
2. Remaining bitmanip instructions not ratified as part of v.1.00 of
   the bitmanip spec are upgraded to the latest draft (v.0.93).
3. Simultaneous use of the v.1.00 bitmanip instructions and those
   instructions only part of draft v.0.93 is enabled.
4. Rename bext/bdep to bcompress/bdecompress. This is part of v.0.94.
   But it's needed as in v.0.93 as well as in v.1.00 sbext from Zbs
   is renamed to bext, leading to two completely different instructions
   having the same name.
5. Increase the MAX_INSTR_STR_LEN parameter to accomodate longer
   instruction names (bdecompressw has 12 characters).

Signed-off-by: Pirmin Vogel <[email protected]>
@vogelpi vogelpi force-pushed the allow-bitmanip-v.1.00-and-v.0.93 branch from d9e4f30 to 3fb3cec Compare December 2, 2021 16:13
Copy link
Contributor

@weicaiyang weicaiyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@weicaiyang weicaiyang merged commit ea8dd25 into chipsalliance:master Dec 2, 2021
@weicaiyang
Copy link
Contributor

CI passed, but it got this error after merging this PR. Does anyone know what happens?

Run ./scripts/metrics-regress.py $METRICS_REGRESSION_NAME $METRICS_PROJECT_ID
Error, regression was not started. Response: 400:Bad Request {'message': 'Failed to get new access token using refresh token.', 'code': 'ERROR_REFRESHING_TOKEN'}
Exit with code 1
Error: Process completed with exit code 1.

@vogelpi
Copy link
Contributor Author

vogelpi commented Dec 2, 2021

Thanks a lot @weicaiyang ! Regarding the error, I have don't really have an idea what this is about. But it seems also previous PRs got the same error. Could it be that this metrics script got somehow outdated?

@weicaiyang
Copy link
Contributor

Thanks a lot @weicaiyang ! Regarding the error, I have don't really have an idea what this is about. But it seems also previous PRs got the same error. Could it be that this metrics script got somehow outdated?

I see. Let me file an issue for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants