Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement missing types #11

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Conversation

chmp
Copy link
Owner

@chmp chmp commented Oct 13, 2024

  • Sparse union arrays
  • Interval arrays
    • the arrays are using types without bytemuck support. How can they be safely cast into a common repr (in particular for views)? For arrow the crate offers a view as a &[u8] which could be (safely) transmuted
    • Before "arrow=52" the Interval types are broken (issue). The bits generated by marrow are still correct, but the tests will fail
    • Figure out whether the alignment is an issue. See here
      • the structured types are aligned to their largest member (4 bytes for DayTime, 8 bytes for MonthDayNano)
  • Run end encoding arrays
  • Document
    • Include note about the Interval impl before arrow=52

@chmp chmp changed the title Add SparsUnion support, Add interval datatype Implement missing types Oct 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant