-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add json transcoding benchmarks #130
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hey @Ten0, Thanks a lot for the PR. The performance is unfortunate. But good to know. Overall the changes look good to me. I will add a couple of comments to the code. Some meta comments:
|
chmp
requested changes
Feb 3, 2024
chmp
reviewed
Feb 18, 2024
|
chmp
approved these changes
Feb 18, 2024
@Ten0 in case you're interested. I also added simd_json and rewrote all benchmarks to use the JSON line repr. These are the numbers, I get:
|
Thanks for PR! |
Thanks for closing it out! 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #129
Also allows serializing
unit
asnull
to enable transcoding (non-hinted deserializers will typically yield unit when encountering null).Current benchmark results:
(TL;DR going through serde_json seems very slow compared to arrow-json's tailored JSON parser)