Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for borrowed strings #151

Merged
merged 4 commits into from
Mar 25, 2024
Merged

Add support for borrowed strings #151

merged 4 commits into from
Mar 25, 2024

Conversation

gstvg
Copy link
Contributor

@gstvg gstvg commented Mar 22, 2024

This allows deserializing into strings borrowed from the original arrow arrays

@chmp
Copy link
Owner

chmp commented Mar 25, 2024

Really cool. Thanks for the PR. @gstvg !

@chmp
Copy link
Owner

chmp commented Mar 25, 2024 •
edited
Loading

I changed some small things:

  • Fixed a small bug in the x.py script
  • Restored the original signature of the deserialize test method and added a separate test method for borrowed deserialization (that is used by the non-borrowed deserialize method)
  • Updated the changelog to document your contribution

@chmp chmp merged commit 90310cd into chmp:main Mar 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gstvg @chmp