Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to align with the new (2024/Feb) libnfs API #15

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

cwedgwood
Copy link
Contributor

bump the version to reflect this

bump edition to 2021

bump the version to reflect this

bump edition to 2021
@cwedgwood
Copy link
Contributor Author

@cholcombe973 this is working for me though testing is limited, i'm not sure if this needs further work and it's not clear (to me) if it should go into the main branch

it will fail CI because that is using the older libnfs

Copy link
Owner

@cholcombe973 cholcombe973 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these changes all look fine. I've only done some light testing as well. We could probably setup an integration test in the GitHub workflow if we wanted that could validate it.

Cargo.toml Outdated Show resolved Hide resolved
@cwedgwood
Copy link
Contributor Author

@cholcombe973

OK, there are a few things going on here which I didn't plan on initially.

I'm using the rs- prefix to disambiguate this from libnfs. In general, I'm not a fan of such prefixes but it seems hard to avoid given libnfs is already a thing and it is reasonable to have them both checked out at the same time in the same place. As the crate exists with the old name ... I'm not sure what if anything you want to do here.

To utilize the new updated libnfs I'm cloning it from my repo, it could and probably should come from upstream, but as this was in flux I wanted something I could confirm was working (this can be solved by using ref later).

I need this to rebuild libnfs-sys with the updated libnfs - to make this work I have the dependency of type git - again pointing to my repo for the same reasons as needing it to work and be a known quantity.

I made some minor restructuring to the workflow to accommodate this and perhaps leave for other things later.

@cwedgwood
Copy link
Contributor Author

@cholcombe973 another small update to use canonical upstream repos and specific (tested) refs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants