-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to align with the new (2024/Feb) libnfs API #15
base: master
Are you sure you want to change the base?
Conversation
bump the version to reflect this bump edition to 2021
@cholcombe973 this is working for me though testing is limited, i'm not sure if this needs further work and it's not clear (to me) if it should go into the main branch it will fail CI because that is using the older libnfs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think these changes all look fine. I've only done some light testing as well. We could probably setup an integration test in the GitHub workflow if we wanted that could validate it.
OK, there are a few things going on here which I didn't plan on initially. I'm using the To utilize the new updated I need this to rebuild I made some minor restructuring to the workflow to accommodate this and perhaps leave for other things later. |
6c5b59b
to
c37a4ac
Compare
c37a4ac
to
d623850
Compare
@cholcombe973 another small update to use canonical upstream repos and specific (tested) refs. |
bump the version to reflect this
bump edition to 2021