#63 Display results in detail view

chovanecm · Mar 25, 2018 · 7423086 · 7423086
1 parent 920ee07
commit 7423086
Show file tree

Hide file tree

Showing 4 changed files with 37 additions and 8 deletions.
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "sacredboard",
-  "version": "0.4.1-dev1",
+  "version": "0.4.1-dev2",
   "description": "Sacredboard NPM package file for automatic tests.",
   "dependencies": {},
   "devDependencies": [

diff --git a/sacredboard/static/scripts/runs/detailView/template.html b/sacredboard/static/scripts/runs/detailView/template.html
@@ -21,6 +21,11 @@ <h3>Details for: <!--ko text: run.experiment_name--><!--/ko-->
                     <a data-bind="attr: {href: '#captured-output-' + run.id}"
                        data-toggle="pill">Captured output</a>
                 </li>
+                <li role="presentation">
+                    <a data-bind="attr: {href: '#experiment-result-' + run.id}"
+                       data-toggle="pill">Result</a>
+                </li>
+
                 <li role="presentation">
                     <a data-bind="attr: {href: '#experiment-experiment-' + run.id}"
                        data-toggle="pill">Experiment</a>
@@ -66,6 +71,14 @@ <h4>Run info</h4>
                             params="value: run.object.info"></dictionary-browser>
                 </div>
             </div>
+            <div data-bind="attr: {id: 'experiment-result-' + run.id}"
+                 class="tab-pane table-responsive">
+                <h4>Result</h4>
+                <div class="detail-page-box">
+                    <dictionary-browser
+                            params="value: run.result"></dictionary-browser>
+                </div>
+            </div>
             <div data-bind="attr: {id: 'experiment-experiment-' + run.id}"
                  class="tab-pane table-responsive">
                 <h4>Experiment</h4>

diff --git a/sacredboard/static/scripts/runs/dictionaryBrowser/template.html b/sacredboard/static/scripts/runs/dictionaryBrowser/template.html
@@ -1,8 +1,24 @@
 <table class="table table-condensed table-hover"
-       data-bind="foreach: {data: dict.getChildren(), as: 'entry'}"
         style="border-left: groove">
-    <tr data-bind="click: entry.toggleCollapse,
-                   css: { 'cursor-pointer': entry.hasChildren() }"><td data-bind="text: entry.getDisplayName()"></td><td data-bind="text: entry.getDisplayValue()"></td></tr>
-    <tr data-bind="visible: !entry.contentCollapsed()">
-        <td colspan="2" style="padding-top: 0"><dictionary-browser params="value: entry.value"></dictionary-browser></td></tr>
-</table>
+    <!-- ko ifnot: dict.hasChildren() -->
+        <tbody>
+            <tr><td data-bind="text: dict.getDisplayValue()"></td></tr>
+        </tbody>
+    <!-- /ko -->
+    <!-- ko if: dict.hasChildren() -->
+    <tbody data-bind="foreach: {data: dict.getChildren(), as: 'entry'}">
+        <tr data-bind="click: entry.toggleCollapse,
+                       css: { 'cursor-pointer': entry.hasChildren() }">
+            <td data-bind="text: entry.getDisplayName()"></td>
+            <td data-bind="text: entry.getDisplayValue()"></td>
+        </tr>
+        <!-- ko if: entry.hasChildren() -->
+            <tr data-bind="visible: !entry.contentCollapsed()">
+                <td colspan="2" style="padding-top: 0">
+                    <dictionary-browser params="value: entry.value"></dictionary-browser>
+                </td>
+            </tr>
+        <!-- /ko -->
+    </tbody>
+    <!-- /ko -->
+</table>
diff --git a/sacredboard/tests/app/test_sacredboard.py b/sacredboard/tests/app/test_sacredboard.py
@@ -5,4 +5,4 @@
 
 class TestSacredboard(TestCase):
     def test_get_version(self):
-        assert Sacredboard.get_version() == "0.4.1.dev1"
+        assert Sacredboard.get_version() == "0.4.1.dev2"