Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a verification to only appear the prompt on Safari #69

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

juancarlosjr97
Copy link

Currently, the prompt appears on all the browser using iOS or iPad. The changes made check if the browser is Safari to show the prompt or not.

@PegasisForever
Copy link

@juancarlosjr97
Copy link
Author

Do you mean to confirm is Safari, not Google Chrome or Firefox @PegasisForever ?

@PegasisForever
Copy link

PegasisForever commented Feb 5, 2021

Yes, if we found FxiOS or CriOS in the ua, we are 100% sure it's not safari

@juancarlosjr97
Copy link
Author

@PegasisForever apparently is an issue mozilla-mobile/firefox-ios#6620 any thoughts?

@martinbroos
Copy link

martinbroos commented Jul 23, 2021

If only Safari has support for 'add to homescreen' than this pr seems right to me. If you are gonna detect firefox and chrome on iOS than there are probably more browsers that can be installed on iOS. Not sure if chrome and firefox on iOS support native PWA detection ?

But still this pull request seems the best step forward to me.

@juancarlosjr97
Copy link
Author

If only Safari has support for 'add to homescreen'

Yes @martinbroos, the only browser on iOS that allows adding to the home screen a PWA is Safari.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants