Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update names of methods, variables, and other elements #181

Merged
merged 9 commits into from
Aug 14, 2023
Merged

Conversation

chrisdill
Copy link
Owner

@chrisdill chrisdill commented Aug 5, 2023

PR preparing to merge naming changes from #167.

@chrisdill chrisdill changed the title Dev Update names of methods, variables, and other elements Aug 5, 2023
@MrScautHD
Copy link
Contributor

MrScautHD commented Aug 6, 2023

anything else what need todo?

@chrisdill chrisdill marked this pull request as ready for review August 7, 2023 18:58
@chrisdill
Copy link
Owner Author

@MrScautHD Changes look good. Last few checks then this will be merged.

@anggape anggape mentioned this pull request Aug 8, 2023
@MrScautHD
Copy link
Contributor

What about changing the name from classes to something like from Raymath to RayMath

@chrisdill
Copy link
Owner Author

I think the interop class naming is fine as it is. I see Raymath as one full word like Raylib.

@MrScautHD
Copy link
Contributor

well, what about the namespace?

like Raylib_cs is a bit wierd, what about just calling it Raylib?

@chrisdill
Copy link
Owner Author

The namespace is called that to help make it clearer that it is a binding to raylib. Also the main interop class is already called Raylib.

@MrScautHD
Copy link
Contributor

MrScautHD commented Aug 12, 2023

The namespace is called that to help make it clearer that it is a binding to raylib. Also the main interop class is already called Raylib.

mhh, well it is your lib.

Anyway did you saw anything else that need to be changed or fixed?

@MrScautHD
Copy link
Contributor

AnsiBuffer need to be fixed to now!

@chrisdill
Copy link
Owner Author

@MrScautHD Looks good. Merged!

@MrScautHD
Copy link
Contributor

Amazing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants