Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port to Raylib-5.0.0 #210

Merged
merged 22 commits into from
Dec 27, 2023
Merged

Port to Raylib-5.0.0 #210

merged 22 commits into from
Dec 27, 2023

Conversation

MrScautHD
Copy link
Contributor

@MrScautHD MrScautHD commented Nov 19, 2023

This pull request is a work in progress (WIP).
I have initiated the process by beginning the port to Raylib-5.0.0.

Issue: #209

@MrScautHD MrScautHD marked this pull request as draft November 19, 2023 11:06
@MrScautHD MrScautHD marked this pull request as ready for review November 19, 2023 11:32
@MrScautHD
Copy link
Contributor Author

Android got a build error has anyone a idea why?

@chrisdill
Copy link
Owner

Seems to be a difference in how warnings are handled when comparing it to the other platform builds. Not sure why though.

@akgvn
Copy link

akgvn commented Nov 19, 2023

@MrScautHD the problem seems to be related to this: raysan5/raylib#3491

Edit: CMakeLists.txt file needs patching similar to how its done here: https://github.com/Bigfoot71/Raymob/blob/cb0bd177c8266b9e623f1cdf496e07fb251d5173/app/src/main/cpp/deps/raylib/CMakeLists.txt#L26

Another option is to use the makefile instead of cmake since that already handles the problem in raylib main branch: https://github.com/raysan5/raylib/blob/7e60227720515143712e1df9e78e7a6ecfc46169/src/Makefile#L361-L366

@MrScautHD
Copy link
Contributor Author

@MrScautHD the problem seems to be related to this: raysan5/raylib#3491

Edit: CMakeLists.txt file needs patching similar to how its done here: https://github.com/Bigfoot71/Raymob/blob/cb0bd177c8266b9e623f1cdf496e07fb251d5173/app/src/main/cpp/deps/raylib/CMakeLists.txt#L26

Another option is to use the makefile instead of cmake since that already handles the problem in raylib main branch: https://github.com/raysan5/raylib/blob/7e60227720515143712e1df9e78e7a6ecfc46169/src/Makefile#L361-L366

ah ok, sadly im very bad in msBuild so can anyone fix that for me? (Or merge it and fix it with a commit)

@9ParsonsB 9ParsonsB marked this pull request as draft November 19, 2023 23:18
@CodingMadness
Copy link

Is the port still going on?

@MrScautHD
Copy link
Contributor Author

Yea, but idk how to fix the android build i would like if anyone could help ☺️

@CodingMadness
Copy link

Yea, but idk how to fix the android build i would like if anyone could help ☺️

I will dive into this when I see time, need 2 days tho due to some work I will have to do for my job, then I will look into it with pleasure.

@MrScautHD
Copy link
Contributor Author

Yea, but idk how to fix the android build i would like if anyone could help ☺️

I will dive into this when I see time, need 2 days tho due to some work I will have to do for my job, then I will look into it with pleasure.

And do you know how to fix it?

@CodingMadness
Copy link

Yea, but idk how to fix the android build i would like if anyone could help ☺️

I will dive into this when I see time, need 2 days tho due to some work I will have to do for my job, then I will look into it with pleasure.

And do you know how to fix it?

Big sry, I was getting sick lately and it lasted like 11 days.. and had to prepare for christmas and such, so my head where no where really.

But today I asked abit the owner of raylib and he replied this:

chatlog.txt

Hope that gets you a bit of an idea of what is going wrong.

@MrScautHD
Copy link
Contributor Author

@chrisdill What do you think by doing a own branch for it so everyone can help to port to Raylib-5.0

@chrisdill chrisdill changed the base branch from master to dev December 26, 2023 10:14
@MrScautHD
Copy link
Contributor Author

finally :D

@MrScautHD MrScautHD marked this pull request as ready for review December 27, 2023 10:32
@MrScautHD
Copy link
Contributor Author

@chrisdill it should be done.

@chrisdill chrisdill changed the base branch from dev to master December 27, 2023 12:15
@chrisdill
Copy link
Owner

@MrScautHD Looks good. Thanks for fixing the build issue!

@chrisdill chrisdill merged commit 43f1924 into chrisdill:master Dec 27, 2023
@CodingMadness
Copy link

@chrisdill it should be done.

Was my last message somewhat useful 😅 ?

@Odex64
Copy link

Odex64 commented Jan 1, 2024

You really should update the NuGet package.
Also consider switching to .NET 8 since it's LTS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants