Python 3 support #11
Open
Python 3 support #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(I should add that my chief use case and test case was your notebook for converting midi files to NES wav files.) |
|
Whoa this looks like a heroic and monumental effort. Thx so much for this! I will do some testing on this ASAP and get back to you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, thanks very much for this really incredible work! I've been reading some of your papers (including your dissertation, which is really fantastic!) and have learned a great deal from your writing. I have lots of questions on downstream machine learning tasks but this probably isn't the place for those...
I was hoping to use this library for some work in Python 3, and it looked like a few folks started some pull requests to offer Python 3 support, but none had quite sorted out the differences between byte sequence data in Python 2 and 3, so I wanted to give it a go.
In any event, this PR offers Python 3 support for the library. I also updated the setup.py file to allow users with OSX machines to install the VGMPlay dependency.
I also made the questionable decision to remove the errors that used to spring when one failed to build VGMPlay. My thought was that, rather than force e.g. Windows users to have to hack the VGMPlay Makefile in setup.py, maybe it'd make sense to let users compile VGMPlay and then just move the executable to the location on the filesystem where this library is located after installation. That way users like the Windows OS user in the issue tracker could compile the executable using whatever means necessary and then just move the executable to the proper location for use by this library.
In any event I'm happy to change any element of this if you like. Either way thanks again for this great work!