-
-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flex flavor (w/ webkit prefixes) #4
Conversation
Flex shorthand uses a default value for flex-basis that collapses if growth is not possible
👍 awesome! @chrisnager is this something you want to add as an extra "option" in ungrid? |
Any news ? |
Hi @sherbrow, I've just noticed that the column widths are not distributed evenly with using Adding an additional |
Maybe worth adding: another nice way for specific column widths: |
@rkusa It is the expected behavior of flex, a little like table cells that adapt to their content. I'm not sure forcing the basis to 0 is the best default behavior, even considering it is the default value of the flex shorthand. About |
@sherbrow Thanks for the response! Yes it is, I just wanted to note that the current behaviour is different from that of ungrid using the table layout approach (with fixed table layout). |
@chrisnager have you had the time to review? :-) |
@chrisnager Thank you for the late effort ! Very much appreciated ;) |
The flex flavored version as I think it would allow a lot more than mere tables.
Safari is till using prefixes but that's not too problematic I guess : Can I Use Flex
Added a doc page too (a copy of the index.html) and it would be even better if it explained the flex version and a few of the very useful flex properties (maybe even a .css with classes to apply those properties to the rows and cols).
http://sherbrow.github.io/ungrid/flex.html