-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Dockerized chroma arguments customization (#1658)
## Description of changes *Summarize the changes made by this PR.* - New functionality - Added an ability to customize the default arguments that are passed from `docker run` or `docker compose` `command` field to `uvicorn chromadb.app:app`. I needed it to be able to customize the port because in certain scenarios it cannot be change (i.e. ECS where internal port is proxies as is). The default arguments are not changed: `--workers 1 --host 0.0.0.0 --port 8000 --proxy-headers --log-config chromadb/log_config.yml --timeout-keep-alive 30` - Added ENV variables for basic customization with default values: ``` CHROMA_HOST_ADDR="0.0.0.0" CHROMA_HOST_PORT=8000 CHROMA_WORKERS=1 CHROMA_LOG_CONFIG="chromadb/log_config.yml" CHROMA_TIMEOUT_KEEP_ALIVE=30 ``` ## Test plan *How are these changes tested?* - Tested locally using `docker build` and `docker run` commands - Tested customization in `docker-compose` - now it works as expected. ## Documentation Changes *Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the [docs repository](https://github.com/chroma-core/docs)?* TODO: Deployment docs needs to be updated to cover container arguments customization.
- Loading branch information
1 parent
a62cfb0
commit 691ac3f
Showing
5 changed files
with
24 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,15 @@ | ||
#!/bin/bash | ||
set -e | ||
|
||
export IS_PERSISTENT=1 | ||
export CHROMA_SERVER_NOFILE=65535 | ||
exec uvicorn chromadb.app:app --workers 1 --host 0.0.0.0 --port 8000 --proxy-headers --log-config chromadb/log_config.yml --timeout-keep-alive 30 | ||
args="$@" | ||
|
||
if [[ $args =~ ^uvicorn.* ]]; then | ||
echo "Starting server with args: $(eval echo "$args")" | ||
echo -e "\033[31mWARNING: Please remove 'uvicorn chromadb.app:app' from your command line arguments. This is now handled by the entrypoint script." | ||
exec $(eval echo "$args") | ||
else | ||
echo "Starting 'uvicorn chromadb.app:app' with args: $(eval echo "$args")" | ||
exec uvicorn chromadb.app:app $(eval echo "$args") | ||
fi |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters