[Bug]: 500 server error on a collection not found

[dblock]

What happened?

Fetching a collection by name via the HTTP API fails with a 500 Internal Server Error. Should be a 404.

Versions

Chroma 0.4.6, OSX.

Relevant log output

$ curl http://localhost:8000/api/v1/collections/foobar -v
*   Trying 127.0.0.1:8000...
* Connected to localhost (127.0.0.1) port 8000 (#0)
> GET /api/v1/collections/foobar HTTP/1.1
> Host: localhost:8000
> User-Agent: curl/7.88.1
> Accept: */*
> 
< HTTP/1.1 500 Internal Server Error
< date: Thu, 27 Jul 2023 19:34:19 GMT
< server: uvicorn
< content-length: 59
< content-type: application/json
< 
* Connection #0 to host localhost left intact
{"error":"ValueError('Collection foobar does not exist.')"}

[huineng]

Correct , even
try
Except ValueError as e
does not work , only (Exception as e) does

[tazarov]

@dblock I have a PR coming for this:

curl http://localhost:8000/api/v1/collections/foobar -v
*   Trying 127.0.0.1:8000...
* Connected to localhost (127.0.0.1) port 8000 (#0)
> GET /api/v1/collections/foobar HTTP/1.1
> Host: localhost:8000
> User-Agent: curl/8.1.2
> Accept: */*
> 
< HTTP/1.1 404 Not Found
< date: Mon, 07 Aug 2023 07:00:18 GMT
< server: uvicorn
< content-length: 76
< content-type: application/json
< 
* Connection #0 to host localhost left intact
{"error":"CollectionNotFound","message":"Collection foobar does not exist."}

[jeffchuber]

@tazarov did this commit land somewhere?

[tazarov]

@jeffchuber, I think this PR will resolve the issue - #991. I'll close my PR and do any additional enhancements I did there once #991 gets merged.