Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

identity to equality check #1566

Merged
merged 2 commits into from
Dec 23, 2023
Merged

Conversation

carlsonp
Copy link
Contributor

@carlsonp carlsonp commented Dec 22, 2023

Description of changes

Changes identity is to equality == check

Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readbility, Modularity, Intuitiveness)

@jeffchuber jeffchuber self-requested a review December 22, 2023 04:54
@jeffchuber
Copy link
Contributor

thanks! will get this merged and released

Copy link
Contributor

@jeffchuber jeffchuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

@beggers
Copy link
Contributor

beggers commented Dec 23, 2023

@carlsonp we recently had a CI issue on main which is affecting this branch. If you merge in main tests should pass then I'd be happy to merge this in :^)

@jeffchuber
Copy link
Contributor

@carlsonp I got you :) tests running now!

@beggers beggers merged commit 47447b6 into chroma-core:main Dec 23, 2023
97 checks passed
@beggers
Copy link
Contributor

beggers commented Dec 23, 2023

🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants