Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed typo for Readability #1571

Merged
merged 2 commits into from
Dec 23, 2023
Merged

Fixed typo for Readability #1571

merged 2 commits into from
Dec 23, 2023

Conversation

shmohit2002
Copy link
Contributor

@shmohit2002 shmohit2002 commented Dec 22, 2023

Description of changes

Summarize the changes made by this PR.

  • Improvements & Bug fixes
    • Fixed the Typo in github workflow

Test plan

NA

Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readbility, Modularity, Intuitiveness)

Copy link
Contributor

@beggers beggers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ha, ironic. Once CI passes I'll check this in. Thanks!

@beggers
Copy link
Contributor

beggers commented Dec 23, 2023

Hey @shmohit2002 we recently had a CI issue on main which is affecting this branch. If you merge in main the tests should pass then I'd be happy to check this in :^)

@jeffchuber
Copy link
Contributor

@shmohit2002 nice one! =D

@shmohit2002
Copy link
Contributor Author

Hey @beggers, I have synced the branch. Earlier, I found that a minor fix was needed in the embedding_functions.py, but nvm, those issues are being addressed in other pull requests.
Cheers🥂

@beggers beggers merged commit b8dfa5a into chroma-core:main Dec 23, 2023
97 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants