Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: Fixed raising TypeError instead or ValueError for invalid type #1602

Merged
merged 1 commit into from
Jan 4, 2024
Merged

ENH: Fixed raising TypeError instead or ValueError for invalid type #1602

merged 1 commit into from
Jan 4, 2024

Conversation

Sai-Suraj-27
Copy link
Contributor

Description of changes

At few places in the codebase we are checking the type of something but raising ValueError instead of TypeError.
Improvements & Bug fixes
Raising Proper error messages will be good for both the developers and users.

Test plan

How are these changes tested?

  • Tests pass locally with pytest for python, yarn test for js

Documentation Changes

No documentation changes needed

@github-actions GitHub Actions
Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

beggers
beggers approved these changes Jan 3, 2024
View reviewed changes
Copy link
Contributor

@beggers beggers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

@beggers beggers merged commit a8168eb into chroma-core:main Jan 4, 2024
98 checks passed
thorwhalen pushed a commit to thorwhalen/chroma that referenced this pull request Jan 11, 2024
@Sai-Suraj-27 @thorwhalen
ENH: Fixed raising TypeError instead or ValueError for invalid ty…
498cffa 
…pe (chroma-core#1602)

## Description of changes
At few places in the codebase we are checking the type of something but
raising `ValueError` instead of `TypeError`.
**Improvements & Bug fixes**
Raising Proper error messages will be good for both the developers and
users.


## Test plan
*How are these changes tested?*

- [ ] Tests pass locally with `pytest` for python, `yarn test` for js

## Documentation Changes
No documentation changes needed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beggers beggers beggers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sai-Suraj-27 @beggers