ENH: Validate response of embedding function to be in the expected format during runtime #1615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rmat during runtime
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
beggers
approved these changes
Jan 10, 2024
chromadb/test/api/test_types.py
Outdated
| return [str(random_image()) for _ in range(10)] | ||
|
|
||
|
|
||
| def test_embedding_function_with_valid_response() -> None: |
There was a problem hiding this comment.
nit: could we change these to start with test_embedding_function_results_format_... so it's more immediately clear what they're testing?
chromadb/test/api/test_types.py
Outdated
| ef = TestEmbeddingFunction() | ||
| with pytest.raises(ValueError) as e: | ||
| ef(random_documents()) | ||
| assert "Expected embeddings to be a list, got {'error': 'test'}" == str(e.value) |
There was a problem hiding this comment.
nit: I don't want us to be locked on this error string -- mind removing this line? I'm happy with us simply verifying that we raise a ValueError.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Requested in #1488
Test plan
pytestfor python,yarn testfor jsDocumentation Changes
Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?