Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Add s3 storage for rust worker #1643

Merged
merged 7 commits into from
Jan 17, 2024
Merged

[ENH] Add s3 storage for rust worker #1643

merged 7 commits into from
Jan 17, 2024

Conversation

HammadB
Copy link
Collaborator

@HammadB HammadB commented Jan 16, 2024

Description of changes

Summarize the changes made by this PR.

  • Improvements & Bug fixes
    • Update bin/cluster-test to build rust worker
    • Parameterize dockerfile to support building the docker image for and not for integration tests
    • Add build.rs step for integration tests
    • Make memberlist and storage tests only run in response to this flag
  • New functionality
    • Adds a basic storage system that gets/puts to s3

Test plan

How are these changes tested?
New tests were added for basic use of storage.

  • Tests pass locally with cargo test

Copy link
Collaborator Author

HammadB commented Jan 16, 2024

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@HammadB HammadB changed the title [ENH] Add s3 storage for rust worker [WIP] [ENH] Add s3 storage for rust worker Jan 16, 2024
@HammadB HammadB changed the title [WIP] [ENH] Add s3 storage for rust worker [ENH] Add s3 storage for rust worker Jan 17, 2024
@HammadB HammadB requested a review from beggers January 17, 2024 05:42
Copy link
Contributor

@beggers beggers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

@HammadB HammadB merged commit 7aaf36f into main Jan 17, 2024
99 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants