Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Fix coordinator pulsar tenant and namespace #1650

Merged
merged 2 commits into from
Jan 17, 2024

Conversation

HammadB
Copy link
Collaborator

@HammadB HammadB commented Jan 16, 2024

Description of changes

Summarize the changes made by this PR.

  • Improvements & Bug fixes
    • This aligns the coordinator, rust worker, and python client on default/default as the pulsar tenant/namespace

@HammadB HammadB changed the title Fix coordinator pulsar tenant and namespace [BUG] Fix coordinator pulsar tenant and namespace Jan 16, 2024
Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

Copy link
Contributor

@Ishiihara Ishiihara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HammadB HammadB enabled auto-merge (squash) January 16, 2024 23:57
@HammadB HammadB merged commit 78ad917 into main Jan 17, 2024
95 of 98 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants