Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add auth transport header to docker compose #1653

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

tonisives
Copy link
Contributor

Description of changes

This just adds a missing env variable to docker-compose

Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@jeffchuber
Copy link
Contributor

@tazarov can you take a look here

@tazarov
Copy link
Contributor

tazarov commented Feb 1, 2024

@jeffchuber, tested. Looks good.

image

image

image

@tonisives, thanks for adding this.

@HammadB HammadB enabled auto-merge (squash) February 2, 2024 18:00
@HammadB HammadB merged commit 64b63bb into chroma-core:main Feb 2, 2024
98 checks passed
tazarov pushed a commit to amikos-tech/chroma-core that referenced this pull request Feb 10, 2024
## Description of changes

This just adds a missing env variable to docker-compose
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants