-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: AmazonBedrockEmbeddingFunction support for Cohere Embed models #1675
Conversation
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
Please also update the embedding model documentation: https://github.com/chroma-core/docs/blob/main/docs/embeddings.md Currently the |
There's an open PR from another contributor for the docs - chroma-core/docs#204 |
I've been waiting for the review for JS implementation as well #1659 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few nits.
…e models; Added input_type arg to CohereEF
@tazarov any other changes? |
Our underlying impl has changed and so this PR is not landable as is. That being said - we'd still like to add this functionality and that is now tracked in this issue. |
Description of changes
AmazonBedrockEmbeddingFunction
Test plan
How are these changes tested?
pytest
for pythonAlso, manually tested with python: