Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Add Embedding Function - Universal Sentence Encoder #1723

Closed
wants to merge 1 commit into from

Conversation

csbasil
Copy link

@csbasil csbasil commented Feb 15, 2024

Description of changes

Summarize the changes made by this PR.

  • New functionality
    • Added USE Embedding Function

Test plan

How are these changes tested?

  • Tests pass locally with pytest for python

Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@csbasil csbasil changed the title [ENH] Add Embedding Function - Universal Sentence Encoder (#1722) [ENH] Add Embedding Function - Universal Sentence Encoder Feb 15, 2024
@beggers beggers requested a review from atroyn February 23, 2024 16:55
Copy link
Contributor

@atroyn atroyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks correct, is there a corresponding documentation update?

https://github.com/chroma-core/docs/blob/main/docs/embeddings.md

@csbasil
Copy link
Author

csbasil commented Feb 25, 2024

@atroyn I have created a PR for the same: chroma-core/docs#219

@csbasil csbasil requested a review from atroyn February 26, 2024 03:58
@csbasil
Copy link
Author

csbasil commented Mar 26, 2024

@atroyn @beggers Kindly review the changes requested.

@atroyn atroyn force-pushed the main branch 2 times, most recently from 7da9620 to 3d898ed Compare April 3, 2024 02:32
@atroyn atroyn enabled auto-merge (squash) April 3, 2024 02:35
@atroyn atroyn disabled auto-merge April 3, 2024 02:35
@atroyn
Copy link
Contributor

atroyn commented Apr 3, 2024

@csbasil happy to land this once requested changes are made to the docs: chroma-core/docs#219

@tazarov tazarov mentioned this pull request Apr 24, 2024
@csbasil
Copy link
Author

csbasil commented May 25, 2024

@atroyn I have made requested docs changes. Kindly have a look

@jeffchuber
Copy link
Contributor

Our underlying impl has changed and so this PR is not landable as is.

That being said - we'd still like to add this functionality and that is now tracked in this issue.

@jeffchuber jeffchuber closed this Sep 15, 2024
@jeffchuber jeffchuber mentioned this pull request Sep 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants