-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Add Embedding Function - Universal Sentence Encoder #1723
Conversation
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks correct, is there a corresponding documentation update?
https://github.com/chroma-core/docs/blob/main/docs/embeddings.md
@atroyn I have created a PR for the same: chroma-core/docs#219 |
7da9620
to
3d898ed
Compare
@csbasil happy to land this once requested changes are made to the docs: chroma-core/docs#219 |
@atroyn I have made requested docs changes. Kindly have a look |
Our underlying impl has changed and so this PR is not landable as is. That being said - we'd still like to add this functionality and that is now tracked in this issue. |
Description of changes
Summarize the changes made by this PR.
Test plan
How are these changes tested?
pytest
for python