Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENH] Remove ONNX Logspam #1747

Merged
merged 1 commit into from
Feb 21, 2024
Merged

[ENH] Remove ONNX Logspam #1747

merged 1 commit into from
Feb 21, 2024

Conversation

atroyn
Copy link
Contributor

@atroyn atroyn commented Feb 21, 2024

Description of changes

After 1.17, ONNXRuntime produces scary warnings on mac platforms, because it tries to put our default embedding function into the CoreML execution environment, where it doesn't fit.

This PR suppresses warnings from ONNX within the default embedding function so that users don't see scary warnings.

Test plan

Locally tested via the start_here notebook.

Documentation Changes

N/A

@atroyn Graphite App
Copy link
Contributor Author

atroyn commented Feb 21, 2024

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@atroyn atroyn requested a review from HammadB February 21, 2024 20:55
@github-actions GitHub Actions
Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

HammadB
HammadB approved these changes Feb 21, 2024
View reviewed changes
Copy link
Collaborator

@HammadB HammadB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@atroyn atroyn enabled auto-merge (squash) February 21, 2024 21:03
@atroyn atroyn merged commit 12ad9e6 into main Feb 21, 2024
118 checks passed
@atroyn atroyn deleted the anton/onnx_warning branch February 21, 2024 21:47
atroyn added a commit to csbasil/chroma that referenced this pull request Apr 3, 2024
@atroyn
[ENH] Remove ONNX Logspam (chroma-core#1747)
5f55c4f 
## Description of changes

After 1.17, ONNXRuntime produces scary warnings on mac platforms,
because it tries to put our default embedding function into the CoreML
execution environment, where it doesn't fit.

This PR suppresses warnings from ONNX within the default embedding
function so that users don't see scary warnings.

## Test plan

Locally tested via the `start_here` notebook.

## Documentation Changes
N/A
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HammadB HammadB HammadB approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@atroyn @HammadB