Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Server side pull logs #1764

Merged
merged 18 commits into from
Feb 23, 2024
Merged

[ENH] Server side pull logs #1764

merged 18 commits into from
Feb 23, 2024

Conversation

weiligu
Copy link
Contributor

@weiligu weiligu commented Feb 23, 2024

Description of changes

https://linear.app/trychroma/issue/CHR-296/pull-logs-api

  • PullLogs implementation in DAO
  • PullLogs API for gRPC
  • DB error handling and retry is not included

Test plan

  • DAO tests
  • grpc tests

Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@weiligu weiligu changed the title 02 20 push logs [ENH] pull logs - server side Feb 23, 2024
@weiligu weiligu changed the title [ENH] pull logs - server side [ENH] Server side pull logs Feb 23, 2024
@weiligu
Copy link
Contributor Author

weiligu commented Feb 23, 2024

merge to main from
#1762

@weiligu weiligu merged commit 765e218 into main Feb 23, 2024
117 checks passed
atroyn pushed a commit to csbasil/chroma that referenced this pull request Apr 3, 2024
## Description of changes
https://linear.app/trychroma/issue/CHR-296/pull-logs-api
- PullLogs implementation in DAO
- PullLogs API for gRPC
- DB error handling and retry is not included

## Test plan
- [ ] DAO tests
- [ ] grpc tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant