[ENH] Helm chart #1776
Merged
[ENH] Helm chart #1776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR: This stack of pull requests is managed by Graphite. |
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
beggers
force-pushed
the
02-26-_ENH_Helm_chart
branch
from
3fabf0a
to
533eb52
Compare
nicolasgere
reviewed
Feb 27, 2024
| @@ -24,19 +25,47 @@ spec: | |||
| imagePullPolicy: IfNotPresent | |||
| name: coordinator | |||
| ports: | |||
| - containerPort: 50051 | |||
| - containerPort: {{ .Values.coordinator.port }} | |||
There was a problem hiding this comment.
maybe I would do port not configurable at the container lvl, because it will also require code to listen the port. But I would do the service port configurable?
nicolasgere
reviewed
Feb 27, 2024
| apiVersion: rbac.authorization.k8s.io/v1 | ||
| kind: Role | ||
| metadata: | ||
| namespace: chroma |
nicolasgere
reviewed
Feb 27, 2024
| subjects: | ||
| - kind: ServiceAccount | ||
| name: default | ||
| name: worker-serviceaccount-rolebinding | ||
| namespace: chroma |
nicolasgere
approved these changes
Feb 27, 2024
beggers
force-pushed
the
02-26-_ENH_Helm_chart
branch
from
533eb52
to
429bf29
Compare
atroyn
pushed a commit
to csbasil/chroma
that referenced
this pull request
Apr 3, 2024
## Description of changes *Summarize the changes made by this PR.* - New functionality - Basic helm chart for distributed chroma ## Test plan *How are these changes tested?* - [ ] Tests pass locally with `pytest` for python, `yarn test` for js ## Documentation Changes *Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the [docs repository](https://github.com/chroma-core/docs)?*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Summarize the changes made by this PR.
Test plan
How are these changes tested?
pytestfor python,yarn testfor jsDocumentation Changes
Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?