Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG]: Added missing $not_contains operator for WhereDocument #1781

Merged
merged 1 commit into from
Mar 6, 2024
Merged

[BUG]: Added missing $not_contains operator for WhereDocument #1781

merged 1 commit into from
Mar 6, 2024

Conversation

tazarov
Copy link
Contributor

@tazarov tazarov commented Feb 27, 2024

Description of changes

Summarize the changes made by this PR.

  • Improvements & Bug fixes
    • Added missing $not_contains WhereDocument op

Test plan

How are these changes tested?

  • Tests pass locally with yarn test for js

Documentation Changes

N/A

@github-actions GitHub Actions
Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@tazarov
Copy link
Contributor Author

tazarov commented Feb 27, 2024

@jeffchuber, PTAL.

@HammadB HammadB merged commit 276226b into chroma-core:main Mar 6, 2024
118 checks passed
atroyn pushed a commit to csbasil/chroma that referenced this pull request Apr 3, 2024
@tazarov @atroyn
[BUG]: Added missing $not_contains operator for WhereDocument (chroma…
dcf5030 
…-core#1781)

## Description of changes

*Summarize the changes made by this PR.*
 - Improvements & Bug fixes
	 - Added missing `$not_contains` WhereDocument op

## Test plan
*How are these changes tested?*

- [x] Tests pass locally with `yarn test` for js

## Documentation Changes
N/A
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HammadB HammadB HammadB approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tazarov @HammadB