Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Add "RELEASE" to PR title checker #1785

Merged
merged 1 commit into from
Feb 27, 2024
Merged

[BUG] Add "RELEASE" to PR title checker #1785

merged 1 commit into from
Feb 27, 2024

Conversation

beggers
Copy link
Contributor

@beggers beggers commented Feb 27, 2024

Description of changes

Summarize the changes made by this PR.

  • Improvements & Bug fixes
    • Add "release" to PR title chceker

Test plan

How are these changes tested?

  • Tests pass locally with pytest for python, yarn test for js

Documentation Changes

Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?

@beggers beggers enabled auto-merge (squash) February 27, 2024 17:53
@beggers Graphite App
Copy link
Contributor Author

beggers commented Feb 27, 2024

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@beggers beggers merged commit c892d47 into main Feb 27, 2024
19 checks passed
@github-actions GitHub Actions
Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

atroyn pushed a commit to csbasil/chroma that referenced this pull request Apr 3, 2024
@beggers @atroyn
[BUG] Add "RELEASE" to PR title checker (chroma-core#1785)
9e47798 
## Description of changes

*Summarize the changes made by this PR.*
 - Improvements & Bug fixes
	 - Add "release" to PR title chceker

## Test plan
*How are these changes tested?*

- [ ] Tests pass locally with `pytest` for python, `yarn test` for js

## Documentation Changes
*Are all docstrings for user-facing APIs updated if required? Do we need
to make documentation changes in the [docs
repository](https://github.com/chroma-core/docs)?*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@beggers