Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENH]: rename go module and move to shared pkg #1810

Merged
merged 5 commits into from
Mar 5, 2024
Merged

[ENH]: rename go module and move to shared pkg #1810

merged 5 commits into from
Mar 5, 2024

Conversation

nicolasgere
Copy link
Contributor

@nicolasgere nicolasgere commented Mar 4, 2024 •
edited
Loading

Description of changes

Summarize the changes made by this PR.

  • Improvements & Bug fixes
    • Rename package in order to match the path to be use as a package.
    • Move otel to shared folder, in order to be use as library in hosted chroma

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 4, 2024

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

weiligu
weiligu approved these changes Mar 4, 2024
View reviewed changes
Copy link
Contributor

@weiligu weiligu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@nicolasgere nicolasgere merged commit 3e6d812 into main Mar 5, 2024
118 checks passed
atroyn pushed a commit to csbasil/chroma that referenced this pull request Apr 3, 2024
@nicolasgere @atroyn
[ENH]: rename go module and move to shared pkg (chroma-core#1810)
c2df732 
## Description of changes

*Summarize the changes made by this PR.*
 - Improvements & Bug fixes
	 - Rename package in order to match the path to be use as a package.
         - Move otel to shared folder, in order to be use as library in hosted
chroma
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weiligu weiligu weiligu approved these changes

@Ishiihara Ishiihara Awaiting requested review from Ishiihara

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicolasgere @weiligu