[ENH] Add rust metadata gprc reader #2075
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 27, 2024
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
HammadB
commented
Apr 27, 2024
| request: pb.QueryMetadataRequest = pb.QueryMetadataRequest( | ||
| segment_id=self._segment["id"].hex, | ||
| where=where_pb, | ||
| where_document=where_document_pb, | ||
| where=self._where_to_proto(where) if where is not None else None, |
There was a problem hiding this comment.
thank you for fixing my silly bugs!
HammadB
commented
Apr 27, 2024
HammadB
commented
Apr 27, 2024
| @@ -91,6 +91,7 @@ impl Operator<BruteForceKnnOperatorInput, BruteForceKnnOperatorOutput> for Brute | |||
| let embedding = match &log_record.record.embedding { | |||
| Some(embedding) => embedding, | |||
| None => { | |||
| // Implies that the record is a delete or update of irrelevant field | |||
There was a problem hiding this comment.
we need to go add delete/update
beggers
reviewed
Apr 29, 2024
| RECORD = "urn:chroma:segment/record" | ||
| BLOCKFILE_METADATA = "urn:chroma:segment/metadata/blockfile" |
There was a problem hiding this comment.
what is urn? i'm guessing this is just some common context in the rust codebase that i'm missing
There was a problem hiding this comment.
we use https://en.wikipedia.org/wiki/Uniform_Resource_Name for the name of the segment types 🤷
| request: pb.QueryMetadataRequest = pb.QueryMetadataRequest( | ||
| segment_id=self._segment["id"].hex, | ||
| where=where_pb, | ||
| where_document=where_document_pb, | ||
| where=self._where_to_proto(where) if where is not None else None, |
There was a problem hiding this comment.
thank you for fixing my silly bugs!
4 tasks
HammadB
added a commit
that referenced
this pull request
May 7, 2024
## Description of changes Replaces #2075 for merge conflict reasons :) *Summarize the changes made by this PR.* - Improvements & Bug fixes - Fixes a bug in grpc metadata stub that does not pass None for where/where_document New functionality - Adds the rust server bindings for metadata reader - Adds the metadata query orchestrator. For now this only handles get by ids (query_ids) it does not handle where/where_document and will error if requested. Todo before we merge this - [x] document handling in record segment - [x] document handling of read logs - i'd like to pull the special magic keys "chroma:document" out and make them first class fields everywhere except transport in rust. Todo after - [ ] updates/deletes ## Test plan *How are these changes tested?* - [x] Tests pass locally with `pytest` for python, `yarn test` for js, `cargo test` for rust ## Documentation Changes None
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Summarize the changes made by this PR.
Todo before we merge this
Todo after
Test plan
How are these changes tested?
pytestfor python,yarn testfor js,cargo testfor rustDocumentation Changes
None