-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH]: Add mlx embedding function #2275 #2295
Conversation
[FEAT] Add mlx embedding [FEAT] Add mlx embedding
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @Rehan-shah; this is a good start, but it requires a bit more work to make it useful.
Take a look at the comments below, and let's discuss if you have any questions or are unsure how to proceed.
Thank you for your assistance. I have implemented the suggested changes. Once approved, I will proceed with editing the documentation. Please let me know if any further adjustments are necessary |
making changes adding changes said
Our underlying impl has changed and so this PR is not landable as is. That being said - we'd still like to add this functionality and that is now tracked in this issue. |
[FEAT] Add mlx embedding
Ref: #2275 #1751
Description of changes
Test plan
I tested It. I used the updated requirements to make a venv and tested by making a simple vector db with few entries.
Documentation Changes
I made changes to docs, add a entry about mlx embeddings