Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH]: Add mlx embedding function #2275 #2295

Closed
wants to merge 2 commits into from

Conversation

Rehan-shah
Copy link

@Rehan-shah Rehan-shah commented Jun 5, 2024

[FEAT] Add mlx embedding
Ref: #2275 #1751

Description of changes

  • New functionality
    • Adding the ability to use mlx models in chroma db

Test plan

I tested It. I used the updated requirements to make a venv and tested by making a simple vector db with few entries.

Documentation Changes

I made changes to docs, add a entry about mlx embeddings

[FEAT] Add mlx embedding

[FEAT] Add mlx embedding
Copy link

vercel bot commented Jun 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
chroma ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 6, 2024 6:51am

Copy link

github-actions bot commented Jun 5, 2024

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

Copy link
Contributor

@tazarov tazarov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @Rehan-shah; this is a good start, but it requires a bit more work to make it useful.

Take a look at the comments below, and let's discuss if you have any questions or are unsure how to proceed.

chromadb/utils/embedding_functions.py Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
requirements.txt Outdated Show resolved Hide resolved
chromadb/utils/mlx_model.py Outdated Show resolved Hide resolved
chromadb/utils/mlx_model.py Outdated Show resolved Hide resolved
chromadb/utils/embedding_functions.py Outdated Show resolved Hide resolved
chromadb/utils/embedding_functions.py Outdated Show resolved Hide resolved
@tazarov tazarov changed the title feat: Add mlx embedding function #2275 [ENH]: Add mlx embedding function #2275 Jun 5, 2024
@tazarov tazarov added the EF Embedding Functions label Jun 5, 2024
@Rehan-shah
Copy link
Author

Thank you for your assistance. I have implemented the suggested changes. Once approved, I will proceed with editing the documentation. Please let me know if any further adjustments are necessary

making changes

adding changes said
@jeffchuber
Copy link
Contributor

Our underlying impl has changed and so this PR is not landable as is.

That being said - we'd still like to add this functionality and that is now tracked in this issue.

@jeffchuber jeffchuber closed this Sep 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EF Embedding Functions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants