Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC]: Fix missing OpenLIT reference in Integration sidenav #2339

Merged
merged 2 commits into from
Jun 17, 2024

Conversation

patcher9
Copy link

@patcher9 patcher9 commented Jun 14, 2024

Description of changes

OpenLIT integration reference was not added to the sidenav in the previous PR. This fixes by adding the OpenLIT SDK to the sidenav

Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@patcher9 patcher9 changed the title [Docs]: Add OpenLIT to the sidenav [DOC]: Add OpenLIT to the sidenav Jun 14, 2024
@patcher9 patcher9 changed the title [DOC]: Add OpenLIT to the sidenav [DOC]: Fix missing OpenLIT reference in Integration sidenav Jun 14, 2024
@patcher9
Copy link
Author

@codetheweb This was missed in the previous PR.

Also not sure but the workflow after the merge seems to have failed.

@codetheweb
Copy link
Contributor

thanks!

Also not sure but the workflow after the merge seems to have failed.

yeah, this is unrelated to the docs PR

@codetheweb codetheweb merged commit 2ea2ba2 into chroma-core:main Jun 17, 2024
9 checks passed
Anush008 pushed a commit to Anush008/chroma that referenced this pull request Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants