-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] add panics to tracing #2382
Conversation
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
7936063
to
dbbeb92
Compare
@@ -54,8 +54,8 @@ RUN if [ "$RELEASE_MODE" = "1" ]; then mv target/release/compaction_service .; e | |||
|
|||
FROM debian:bookworm-slim as compaction_service | |||
|
|||
RUN apt-get update && apt-get install -y libssl-dev ca-certificates |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
makes incremental builds slightly faster
|
||
// Add panics to tracing | ||
let prev_hook = std::panic::take_hook(); | ||
std::panic::set_hook(Box::new(move |panic_info| { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for my learning: does this panic hook get set system wide after this call?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, it's a global hook for all threads (https://doc.rust-lang.org/std/panic/fn.set_hook.html)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one question for my learning. Otherwise lgtm
Tested manually with Jaeger.