Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[ENH] 1965 Split up embedding functions" #2394

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

atroyn
Copy link
Contributor

@atroyn atroyn commented Jun 21, 2024

Reverts #2034

Failing on Python 3.9, 3.10, not on any other versions.

Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@atroyn atroyn enabled auto-merge (squash) June 21, 2024 00:13
@atroyn atroyn merged commit 7da06e7 into main Jun 21, 2024
66 checks passed
atroyn added a commit that referenced this pull request Jun 21, 2024
Anush008 pushed a commit to Anush008/chroma that referenced this pull request Jun 27, 2024
Reverts chroma-core#2034

Failing on Python 3.9, 3.10, not on any other versions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant