Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PERF] Use orjson in client #2434

Merged
merged 3 commits into from
Jul 2, 2024
Merged

[PERF] Use orjson in client #2434

merged 3 commits into from
Jul 2, 2024

Conversation

HammadB
Copy link
Collaborator

@HammadB HammadB commented Jul 1, 2024

Screenshot 2024-07-01 at 3 41 44 PM

@HammadB HammadB requested a review from codetheweb July 1, 2024 22:43
Copy link

github-actions bot commented Jul 1, 2024

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@HammadB HammadB requested a review from atroyn July 1, 2024 22:43
@@ -1,4 +1,4 @@
import orjson as json
import orjson
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sort of obfuscation should be considered a crime.

Copy link
Contributor

@codetheweb codetheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, we should probably do this for the async client too?

@HammadB
Copy link
Collaborator Author

HammadB commented Jul 1, 2024

@codetheweb oh yeah woops let me add

@HammadB HammadB enabled auto-merge (squash) July 1, 2024 22:54
@HammadB HammadB merged commit 424ac18 into main Jul 2, 2024
65 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants