[ENH] catch panics in task operators

[codetheweb]

This can't share code with the handler panic-catching-impl because the task has its own reply channel that the handler knows nothing about.

[github-actions]

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

• Can you think of any use case in which the code does not behave as intended? Have they been tested?
• Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
• If appropriate, are there adequate property based tests?
• If appropriate, are there adequate unit tests?
• Should any logging, debugging, tracing information be added or removed?
• Are error messages user-friendly?
• Have all documentation changes needed been made?
• Have all non-obvious changes been commented?

System Compatibility

• Are there any potential impacts on other parts of the system or backward compatibility?
• Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

• Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

[codetheweb]

a little weird but I think this makes sense, since the panic technically happened within a component

[HammadB]

thank you :)

[HammadB]

may want to constrain Err to ChromaError here

[codetheweb]

adding that bound results in needing to add a lot of spurious typings, so imo it's ok to leave it unbounded and introduce it if there's an issue later
anywhere that calls .boxed() or .code() already effectively constrains it

[HammadB]

Sg Hammad Bashir EECS | Cal

…

On Tue, Jul 9, 2024 at 5:19 PM Max Isom ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In rust/worker/src/execution/operator.rs <#2450 (comment)>: > @@ -17,16 +22,45 @@ where async fn run(&self, input: &I) -> Result<O, Self::Error>; } +#[derive(Debug, Error)] +pub(super) enum TaskError<Err> { adding that bound results in needing to add a lot of spurious typings, so imo it's ok to leave it unbounded and introduce it if there's an issue later anywhere that calls .boxed() or .code() already effectively constrains it — Reply to this email directly, view it on GitHub <#2450 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABKW32KJ6JRCWOKQB6I55TTZLR42LAVCNFSM6AAAAABKKMG6DOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCNRXG4ZDMNJZGQ> . You are receiving this because your review was requested.Message ID: ***@***.***>