Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Compaction error replies #2456

Merged
merged 1 commit into from
Jul 4, 2024
Merged

[ENH] Compaction error replies #2456

merged 1 commit into from
Jul 4, 2024

Conversation

HammadB
Copy link
Collaborator

@HammadB HammadB commented Jul 4, 2024

Description of changes

Broadly a TODO cleanup PR

Summarize the changes made by this PR.

  • Improvements & Bug fixes
    • Makes compaction reply with errors
    • Abstracted out terminate_with_error since its heavily duplicated
    • Trace where it made sense
    • NOTE: I left one or two log sites alone, as well as all dispatcher.sends() as I am not sure what to do with these and that is additive.
  • New functionality
    • None

Copy link

github-actions bot commented Jul 4, 2024

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@HammadB HammadB merged commit e2883df into main Jul 4, 2024
64 of 66 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant