Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHORE] Add tracing for task names, materialize logs tracing, and pull logs count #2479

Merged
merged 3 commits into from
Jul 9, 2024

Conversation

HammadB
Copy link
Collaborator

@HammadB HammadB commented Jul 9, 2024

Description of changes

Summarize the changes made by this PR.

  • Improvements & Bug fixes
    • Auto trace all operators by name
    • Add materialize logs instrumentation span where called
    • Add count event for pull logs inside operator
  • New functionality
    • None

Test plan

How are these changes tested?

  • Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes

Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?

Copy link

github-actions bot commented Jul 9, 2024

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@@ -143,21 +143,16 @@ impl WorkerServer {

let mut proto_results_for_all = Vec::new();

let parse_vectors_span = trace_span!("Input vectors parsing");
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this as its not useful and dumps the vectors to the event

@HammadB HammadB enabled auto-merge (squash) July 9, 2024 19:34
@HammadB HammadB merged commit 1e3c3a2 into main Jul 9, 2024
65 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants